[Fleet] Improve fleet server upgrade modal #99796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
botelastic
bot
added
the
Team:Fleet
|
@elasticmachine merge upstream |
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
May 13, 2021
...ns/fleet/public/applications/fleet/sections/agents/components/fleet_server_upgrade_modal.tsx
Outdated
Show resolved
Hide resolved
...ns/fleet/public/applications/fleet/sections/agents/components/fleet_server_upgrade_modal.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
nchaulet
force-pushed
the
fix-99574-fleet-server-upgrade-modal
branch
from
7941595 to
5110781
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 17, 2021
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
May 17, 2021
nchaulet
added a commit
that referenced
this pull request
May 17, 2021
nchaulet
added a commit
that referenced
this pull request
May 17, 2021
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cc @hbharding @mukeshelastic
Resolve #99574
The fleet server modal is never closing unless you click on the checkbox "do not display that message again".
This PR change that to not display the modal if the user has enrolled another agent then the Fleet Server one.
Also the copy changed, the title changed and the text on cloud is now not saying you should install Fleet Server.
UI Change
How to test?
you need to migrate from fleet 7.12 with enrolled agents to 7.13